Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add control design guidelines doc #1687

Merged
merged 5 commits into from
Aug 14, 2023
Merged

Add control design guidelines doc #1687

merged 5 commits into from
Aug 14, 2023

Conversation

adegeo
Copy link
Contributor

@adegeo adegeo commented Aug 8, 2023 •
edited by github-actions bot
Loading

KlausLoeffelmann
KlausLoeffelmann requested changes Aug 10, 2023
View reviewed changes
Copy link
Member

@KlausLoeffelmann KlausLoeffelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits, questions.

Thanks! Looks good!

...esktop-guide/net/winforms/controls-design/snippets/usercontrol-guidelines/vb/UserControl1.vb Show resolved Hide resolved
dotnet-desktop-guide/net/winforms/controls/overview.md Show resolved Hide resolved
dotnet-desktop-guide/net/winforms/controls-design/usercontrol-guidelines.md Outdated Show resolved Hide resolved
dotnet-desktop-guide/net/winforms/controls-design/usercontrol-guidelines.md Show resolved Hide resolved
dotnet-desktop-guide/net/winforms/controls-design/usercontrol-guidelines.md Show resolved Hide resolved
KlausLoeffelmann
KlausLoeffelmann approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@KlausLoeffelmann KlausLoeffelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@adegeo adegeo merged commit 5bb0c8a into main Aug 14, 2023
7 checks passed
@adegeo adegeo deleted the 1669-design branch August 14, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KlausLoeffelmann KlausLoeffelmann KlausLoeffelmann approved these changes

Assignees
No one assigned
Labels
dotnet-desktop/svc winforms/subsvc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Develop controls - Overview and guidelines
3 participants
@adegeo @KlausLoeffelmann @dotnet-bot